The problem is showcased here: #339

Problem

The parseHeight method in Buildings.java did not handle common OSM tagging mistakes where commas are used as decimal separators instead of periods (eg. height=89,10 instead of height=89.10).

This caused incorrect parsing:

• "89,10" was parsed as 8910 meters instead of 89.10 meters
• "89,1 m" was parsed as 891 meters instead of 89.1 meters

According to the OSM height documentation, commas are incorrect but appear frequently in real-world OSM data.

Problem example as in discussion 339:

Solution

Note: this is similar to the solution that JOSM used here: https://josm.openstreetmap.de/ticket/15719

Added a sanitizeHeightValue() method that:

1. Detects commas followed by 1-2 digits (with optional unit suffix like m)
2. Replaces the comma with a period to create valid decimal notation
3. Preserves actual thousand separators (e.g., "1,234" remains unchanged)

Solution example:

Changes

Modified Files

• src/main/java/com/protomaps/basemap/layers/Buildings.java
  • Added sanitizeHeightValue()
  • Updated parseHeight() to sanitize both osmHeight and osmMinHeight parameters

Test Coverage

• src/test/java/com/protomaps/basemap/layers/BuildingsTest.java
  • Added sanitizeHeightValue() test with proper test cases
  • Added parseHeightWithCommaDecimalSeparator() integration test

Examples